Repository navigation
Fixup Building with Rootless Podman - #311
thebeanogamer wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thebeanogamer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
cncf-cla: yes
|
Welcome @thebeanogamer! |
kubernetes-prow
Bot
added
the
size/XS
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The unconditional Podman-only --userns=keep-id option breaks client generation with Docker.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Improves rootless Podman compatibility for the shared OpenAPI client generator, motivated by Java client builds.
Changes:
- Fully qualifies the Maven base image.
- Adds user-namespace mapping and explicit UID:GID settings.
| File | Description |
|---|---|
| openapi/openapi-generator/Dockerfile | Uses the fully qualified Docker Hub image name. |
| openapi/openapi-generator/client-generator.sh | Adjusts container user mapping for rootless Podman. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| echo "--- Running generator inside container..." | ||
| docker run --rm --security-opt="label=disable" -u $(id -u) \ | ||
| docker run --rm --security-opt="label=disable" \ | ||
| --userns=keep-id -u "$(id -u):$(id -g)" \ |
Some fixes I had to manually apply when trying to run the Java builder with rootless Podman.